wire performInteractiveExploration into --deep mode #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connect the unused performInteractiveExploration() to --deep research flow, producing a deterministic element inventory alongside AI analysis. Changes: - Add --deep flag to TUI /research command and CLI - Call performInteractiveExploration after performDeepAnalysis in deep mode - Expand CLICKABLE_ROLES with checkbox, radio, slider, textbox, treeitem - Include unnamed buttons in ARIA collection (mark with unnamed flag) - Remove 30-char link name length filter - Handle unnamed elements with role-only click fallback - Accept maxElements override param, use 50 in deep mode Co-authored-by: Cursor <cursoragent@cursor.com>
|
CodeAnt AI is reviewing your PR. |
codeant-ai
bot
added
the
size:S
Nitpicks 🔍
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
Comment on lines
9
to
+11
| const includeData = args.includes('--data'); | ||
| const target = args.replace('--data', '').trim(); | ||
| const enableDeep = args.includes('--deep'); | ||
| const target = args.replace('--data', '').replace('--deep', '').trim(); |
There was a problem hiding this comment.
Suggestion: The current argument parsing removes the substrings '--data' and '--deep' from the entire args string, so if a URL itself contains these sequences (for example as query parameters), the URL will be mangled before navigation, causing the command to visit an unintended page or an invalid URL; instead, parse args into tokens and strip flags only when they are separate arguments. [logic error]
Severity Level: Major ⚠️
- ❌ /research navigates to wrong page when URL contains flags.
- ⚠️ AI research summary mismatched with user's intended target URL.
Suggested change
| const includeData = args.includes('--data'); | |
| const target = args.replace('--data', '').trim(); | |
| const enableDeep = args.includes('--deep'); | |
| const target = args.replace('--data', '').replace('--deep', '').trim(); | |
| const tokens = args.split(/\s+/).filter(Boolean); | |
| const includeData = tokens.includes('--data'); | |
| const enableDeep = tokens.includes('--deep'); | |
| const target = tokens.filter((t) => t !== '--data' && t !== '--deep').join(' '); |
Steps of Reproduction ✅
1. In the TUI or CLI, run the `/research` command with a URL that legitimately contains
the substring `--deep` or `--data` as part of the URL, for example:
`/research https://example.test/search?q=--deep&x=1 --data`.
This flows into the `ResearchCommand` implementation at
`src/commands/research-command.ts:8` (`execute(args: string)`).
2. The command framework (via `BaseCommand`) invokes `ResearchCommand.execute()` with
`args` equal to `https://example.test/search?q=--deep&x=1 --data` (verified from the
signature and usage at `src/commands/research-command.ts:8-11`).
3. Inside `execute` at `src/commands/research-command.ts:9-11`, the following happens:
- `includeData = args.includes('--data')` becomes `true` because the string ends with
`--data`.
- `enableDeep = args.includes('--deep')` becomes `true` because the query parameter
value is `--deep`.
- `target = args.replace('--data', '').replace('--deep', '').trim()` produces
`https://example.test/search?q=&x=1`, because both occurrences of the substrings
`--data` and `--deep` anywhere in the string are stripped, including the query
parameter value.
4. With this mangled URL, the navigation call
`this.explorBot.agentNavigator().visit(target)` at
`src/commands/research-command.ts:13-15` is executed using
`https://example.test/search?q=&x=1` instead of the user-specified
`https://example.test/search?q=--deep&x=1`, causing the navigator to open the wrong or an
unintended page.
5. After navigation, `const state =
this.explorBot.getExplorer().getStateManager().getCurrentState();` at
`src/commands/research-command.ts:17` retrieves the current page state (the wrong page)
via the underlying `getCurrentState()` implementation (see
`/tmp/pr-review/repo-clones/testomatio/explorbot/7fc8e06e315045d0eda04b721a873f36dd09b4cd/src/action.ts:336-338`),
and `agentResearcher().research(state, ...)` at `src/commands/research-command.ts:22-26`
then performs research on this unintended page, leading to incorrect research results for
the command the user actually entered.Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/commands/research-command.ts
**Line:** 9:11
**Comment:**
*Logic Error: The current argument parsing removes the substrings '--data' and '--deep' from the entire args string, so if a URL itself contains these sequences (for example as query parameters), the URL will be mangled before navigation, causing the command to visit an unintended page or an invalid URL; instead, parse args into tokens and strip flags only when they are separate arguments.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
|
CodeAnt AI finished reviewing your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Connect the unused performInteractiveExploration() to --deep research flow, producing a deterministic element inventory alongside AI analysis.
Changes:
CodeAnt-AI Description
Enable deep interactive exploration during research (--deep) and include unnamed/clickable elements
What Changed
Impact
✅ Deeper UI coverage during research✅ Discover previously ignored unnamed interactive elements✅ Broader interactive element sampling (up to 50 clicks in deep mode)💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.